Repository navigation
docs: separate FPM metadata from optional analytical integration - #229
Arsene12358 wants to merge 2 commits into
Conversation
Signed-off-by: Yiming Liu <yimingl@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (2)Read REVIEW.md before commenting.⚙️ CodeRabbit configuration file Files:
Before making any change under: `python/aisimulate/src/aiconfigurator/generator/**` MUST read: `python/aisimulate/.claude/rules/generator-development.md` Before making any change under `python/aisimulate/collector/**` MUST read: `python/ais...📄 CodeRabbit inference engine (AGENTS.md) Files:
🔀 Multi-repo context ai-dynamo/aiconfigurator, ai-dynamo/dynamoLinked repositories findingsai-dynamo/aiconfigurator
ai-dynamo/dynamo
📝 SummaryRisk: Medium. Human attention should focus on the FPM analytical contract, Qwen3-0.6B example correctness, and installation/review gates before timing collection. Changed behavior and contracts
Evidence supplied
Evidence still missing
WalkthroughThe PR adds a complete FPM model-integration guide, a CPU validation example, FPM contract and transfer-test requirements, and collection handoff guidance. Related onboarding documents now require this procedure before GPU collection planning. ChangesFPM model integration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to The documented validation artifacts retain the FPM identity needed to reproduce collection and prediction inputs, so no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
Signed-off-by: Yiming Liu <yimingl@nvidia.com>
Superseded by #248. The commits from this PR are included in
d03a09f8ee6f762422aa26088621f5ff1abe6299onfeat/fpm-config-onboarding. Its refreshed model-integration guide now describes the available class-independent direct-FPM workflow and optional registered-model/SOL integration using current APIs. Continue review in #248, which remains a draft.The original proposal and its historical evidence are retained below.
Why and what changed
FPM onboarding needs pinned model/deployment metadata, correct resource accounting, and matching whole-forward timing data. The guide separates those shared requirements from the optional procedure for reusing or implementing a registered analytical model. It documents the currently available registered-model/SOL route and the class-independent route planned in a separate decoupling PR, without making an op-level class a universal onboarding prerequisite.
The registered-model procedure covers operation construction, memory/cache accounting, the native FPM analytical contract, and installing a reviewed integration. Its runnable Qwen3-0.6B CPU example distinguishes SOL_FULL diagnostics from FPM interpolation and needs no model weights, GPU, or matching timing pair. Per-operation GPU timing collection is not required. Entry links from the model and FPM workflow guides identify the route choice explicitly.
The planned class-independent route uses validated metadata and direct measured-time interpolation with wider two-sided KV brackets; 2D interpolation remains experimental. Inkling on GB200 with TP, DEP, and TEP is the planned pilot. This documentation introduces no class-independent API or Inkling implementation, and it states that the separate guided foundation currently generates pure-TP configurations only.
Review map
python/aisimulate/docs/fpm/model-integration.md, especially the current/planned route distinction and the conditional registered-model transfer-path tests.Evidence
Updated head:
d338ebc37f2c6e4abc496975bce9e05c33e8a55a.caca6d0f304dc660cce5a12c88cd58ecf6c09270: Python FPM/OpSpec/single-oracle contracts passed 37 tests; native FPM SOL passed 16 and native FPM forward passed 17. Independent reviews, Fast CI, and Full CI passed on that baseline. Those results are historical, not hosted evidence for the documentation update.Modeling and data provenance
No performance data or model implementation is added. Examples use bundled Qwen metadata, the H200 catalog, and CPU analytical checks. The values are analytical estimates rather than measured latency or peak serving memory. Existing contract tests use synthetic fixtures. No GPU collection, Inkling readiness, or predictive accuracy is claimed.
Tracking
Refs AIC-1963 onboarding guidance and AIC-1964 model/resource metadata. Related foundation: #196. The separate decoupling PR implements AIC-1964, AIC-1990, and AIC-1991; this guide does not complete those implementation issues.
The decoupling PR will validate actual CLI predict, recommend, and exported replay against existing MiniMax-M2.7 H200 TP4 and GLM-5.2-NVFP4 B200 DEP8/TEP8 FPM data, including explicit GLM FP8 FMHA identity and classless resource metadata.